Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daylight savings shifts are out of sync #46

Open
m4rk-lewis opened this issue Jun 13, 2024 · 0 comments
Open

daylight savings shifts are out of sync #46

m4rk-lewis opened this issue Jun 13, 2024 · 0 comments

Comments

@m4rk-lewis
Copy link

m4rk-lewis commented Jun 13, 2024

for the sessions function, it would be better to specify the open and close time natively to the timezone that we are targeting using the pytz format. eg:

smc.sessions(df, 'New York', '09:30', '16:00', timezone= "America/New_York")

This is because the daylight savings shifts for each country is not in sync, which means that twice a year, there will be several weeks where New York is in daylight savings, but London isn't or vice versa. The same can be said of other timezones.

M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant