Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart_Series theme is disturbed by add_TA #206

Open
helgasoft opened this issue Dec 10, 2017 · 1 comment
Open

chart_Series theme is disturbed by add_TA #206

helgasoft opened this issue Dec 10, 2017 · 1 comment

Comments

@helgasoft
Copy link

Description

Cannot hide vertical axis through custom theme when add_TA is present in chart_Series.

Expected behavior

add_TA should not interfere with the selected theme. add_BBands, for example, behaves correctly.

Minimal, reproducible example

getSymbols('T', from='2017-06-06')
myTheme <- chart_theme()
myTheme$rylab <- FALSE  		# hide right y-axis
chart_Series(T, theme=myTheme)	        # works ok
chart_Series(T, theme=myTheme, TA='add_TA(EMA(Cl(T)), on=1)')	# does not hide axis
@joshuaulrich
Copy link
Owner

joshuaulrich commented Dec 10, 2017

Thanks for this, and your other chart_Series() reports. Please keep in mind that the chart_Series() code was moved to plot.xts() in xts 0.10-0, and the intention is to make chart_Series() use plot.xts() (see #94). So these reports are likely to remain unaddressed until that migration is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants