Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative data sources to RPC #43

Open
ozgrakkurt opened this issue Jul 16, 2024 · 8 comments
Open

Alternative data sources to RPC #43

ozgrakkurt opened this issue Jul 16, 2024 · 8 comments
Assignees

Comments

@ozgrakkurt
Copy link

Hey,

Did you consider alternative data sources to RPC? What do you think about something like this: https://github.com/enviodev/hypersync-client-rust ?

I am working on hypersync so this is a bit of a shill but It is genuinely a massive upgrade compared to RPC on indexing cases like rindexer

@joshstevens19
Copy link
Owner

Hey JSONRPC was the first release but as explained here https://rindexer.xyz/docs/introduction/what-is-rindexer#future-vision-for-rindexer we want rindexer to not care how the data is synced so for sure want to add many different data sources so would be open to seeing how we could make rindexer hypersync compatible and then editable in the yaml..?

@ozgrakkurt
Copy link
Author

Hey JSONRPC was the first release but as explained here https://rindexer.xyz/docs/introduction/what-is-rindexer#future-vision-for-rindexer we want rindexer to not care how the data is synced so for sure want to add many different data sources so would be open to seeing how we could make rindexer hypersync compatible and then editable in the yaml..?

sounds good! I can implement hypersync as a source if you can ping me when code is ready on the indexer side. Think it can boost the performance a lot

@ozgrakkurt
Copy link
Author

guess just need to make this a trait?

pub struct CreateNetworkProvider {

I can work on converting it into a trait as well if it makes sense. Don't want to distrupt your flow though if you plan to change other things

@joshstevens19
Copy link
Owner

joshstevens19 commented Jul 16, 2024

I am happy to accept a PR for this for sure, way better for you to do then me as you are building the hypersync lol you know way more then me on it.

If its a hyperscan url in the yaml use the hyperscan provider - go for it 💪 shout if you need any help

@dzhelezov
Copy link

Would be happy to add SQD as an alternative data source too!

@joshstevens19
Copy link
Owner

if its as simple as adding this trait and calling via jsonrpc as per the hyperscan URL then sounds good to me would accept a PR @dzhelezov

@joshstevens19
Copy link
Owner

joshstevens19 commented Sep 16, 2024

Someone has submitted a hypersync draft #103

@ozgrakkurt
Copy link
Author

Someone has submitted a hypersync draft #103

To clarify Misha is in hypersync team so the implementation is "official" by envio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants