Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

background images don't load in sections #73

Open
davidem opened this issue Feb 15, 2020 · 2 comments
Open

background images don't load in sections #73

davidem opened this issue Feb 15, 2020 · 2 comments

Comments

@davidem
Copy link

davidem commented Feb 15, 2020

Good afternoon,

I've just updated to the latest and greatest version of Hugo (v0.64.1) and in combination with the current version of reveal-hugo I noticed that background-images no longer load when the slides are within a section. For example:

  • These backgrounds don't load:
+++
weight = 20
+++
{{% section %}}
{{< slide background-image="/images/containers.jpg" background-opacity="0.2" >}}

### Awesome test slide
---

{{< slide background-image="/images/containers.jpg" background-opacity="0.2" >}}

### And yey another cool slide... 

{{% /section %}}
  • These backgrounds do load:
+++
weight = 20
+++
{{< slide background-image="/images/containers.jpg" background-opacity="0.2" >}}

### Awesome test slide
---

{{< slide background-image="/images/containers.jpg" background-opacity="0.2" >}}

### And yet another cool slide... 

And... I use a lot of background images 😎

For the sake of testing I started with a fresh install of both hugo, reveal-hugo and my presentation, not using my custom css.

Cheers,

David

@davidem
Copy link
Author

davidem commented Feb 15, 2020

Figured out a workaround, as it has something to do with the new goldmark markup handler. Set this in the config.toml and the backgrounds render fine:

[markup]
defaultMarkdownHandler = "blackFriday"

@MarionMoseby
Copy link

MarionMoseby commented Jul 10, 2022

I am having this issue, too, and it seems the workaround no longer works :(

EDIT: The original method of using shortcodes now works, so this should be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants