merged into master

Author: masci

Diff for: oauth2_provider/models.py

@@ -109,6 +109,9 @@ def __str__(self):
 class Application(AbstractApplication):
     pass
 
+# Add swappable like this to not break django 1.4 compatibility
+Application._meta.swappable = 'OAUTH2_PROVIDER_APPLICATION_MODEL'
+
 
 @python_2_unicode_compatible
 class Grant(models.Model):

Diff for: oauth2_provider/settings.py

@@ -34,7 +34,7 @@
     'WRITE_SCOPE': 'write',
     'AUTHORIZATION_CODE_EXPIRE_SECONDS': 60,
     'ACCESS_TOKEN_EXPIRE_SECONDS': 36000,
-    'APPLICATION_MODEL': 'oauth2_provider.Application',
+    'APPLICATION_MODEL': getattr(settings, 'OAUTH2_PROVIDER_APPLICATION_MODEL', 'oauth2_provider.Application'),
 
     # Special settings that will be evaluated at runtime
     '_SCOPES': [],

Diff for: oauth2_provider/tests/models.py

@@ -0,0 +1,6 @@
+from django.db import models
+from oauth2_provider.models import AbstractApplication
+
+
+class TestApplication(AbstractApplication):
+    custom_field = models.CharField(max_length=255)

Diff for: oauth2_provider/tests/settings.py

@@ -68,6 +68,7 @@
     'django.contrib.admin',
 
     'oauth2_provider',
+    'oauth2_provider.tests',
 )
 
 LOGGING = {

Diff for: oauth2_provider/tests/test_models.py

@@ -1,6 +1,13 @@
 from __future__ import unicode_literals
 
+try:
+    from unittest import skipIf
+except ImportError:
+    from django.utils.unittest.case import skipIf
+
+import django
 from django.test import TestCase
+from django.test.utils import override_settings
 from django.core.exceptions import ValidationError
 
 from ..models import AccessToken, get_application_model
@@ -72,3 +79,22 @@ def test_str(self):
 
         app.name = "test_app"
         self.assertEqual("%s" % app, "test_app")
+
+@skipIf(django.VERSION < (1, 5), "Behavior is broken on 1.4 and there is no solution")
+@override_settings(OAUTH2_PROVIDER_APPLICATION_MODEL='tests.TestApplication')
+class TestCustomApplicationModel(TestCase):
+    def setUp(self):
+        self.user = UserModel.objects.create_user("test_user", "[email protected]", "123456")
+
+    def test_related_objects(self):
+        """
+        If a custom application model is installed, it should be present in
+        the related objects and not the swapped out one.
+
+        See issue #90 (https://github.com/evonove/django-oauth-toolkit/issues/90)
+        """
+        # Django internals caches the related objects.
+        del UserModel._meta._related_objects_cache
+        related_object_names = [ro.name for ro in UserModel._meta.get_all_related_objects()]
+        self.assertNotIn('oauth2_provider:application', related_object_names)
+        self.assertIn('tests:testapplication', related_object_names)