From e1fa5f6d56e943ce6908803f42b5f6644460f31e Mon Sep 17 00:00:00 2001 From: Ian Bolton Date: Tue, 13 Feb 2024 11:05:35 -0500 Subject: [PATCH] :ghost: Change assessed logic for archetypes to handle zero required (#601) - Currently when no required questionnaires exist, archetypes are marked as `assessed:true` which results in additional UI code to rule out this case when calculating status. This PR aims to return `assessed: false` in the case of zero required assessments for an archetype. Signed-off-by: ibolton336 --- assessment/questionnaire.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/assessment/questionnaire.go b/assessment/questionnaire.go index 905520c9e..eb3da056f 100644 --- a/assessment/questionnaire.go +++ b/assessment/questionnaire.go @@ -47,6 +47,9 @@ func (r *QuestionnaireResolver) Required(id uint) (required bool) { // Assessed returns whether a slice contains a completed assessment for each of the required // questionnaires. func (r *QuestionnaireResolver) Assessed(assessments []Assessment) (assessed bool) { + if r.requiredQuestionnaires.Size() == 0 { + return false + } answered := NewSet() for _, a := range assessments { if r.requiredQuestionnaires.Contains(a.QuestionnaireID) {