-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial sections and SQLite database for MONA Spectral Database (.msp) #27
Comments
Thanks for the feedback!
|
Ah, and regarding 1): I've opened an issue in |
Again, regarding 1): |
many thanks so far! Regarding: https://mona.fiehnlab.ucdavis.edu/downloads |
Hello jorainer,
First of all many thanks for this utterly great and comprehensible tutorial and of course all the wonderful work hidden in the
Spectra
package.I would like to ask some questions about it:
1.) Could function
compareSpectra()
always return typematrix (array)
?. This would it ease up the determination of best_match in case oflength(mbank_sub) == 1
orlength(sps_sub) == 1
.Implicetely I would suggest to introduce a drop = F argument in the return statement of the function for clarity so as to have the individual correct row and col indicees for the respective matching partners (indicess db_sub & sps_sub) ...
2.) As there is also an equivalent for the SQL version of MassBank, namely MONA in https://github.com/computational-metabolomics/msp2db/releases/tag/v0.0.14-mona-23042021
would it be possible to have that included in the turial? Alternatively a tutorial section on how to compare against .msp databases (MsBackendMsp)) would be great.
3.) Any hint on parallelisation would be helpful, especially in case for parallel db-connections when several hundreds of features should be compared.
many thanks
kind regards
Tony
The text was updated successfully, but these errors were encountered: