Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Avaje-Validator] Fix Wiring with Avaje Inject #3613

Open
wants to merge 3 commits into
base: 3.x
Choose a base branch
from
Open

[Avaje-Validator] Fix Wiring with Avaje Inject #3613

wants to merge 3 commits into from

Conversation

SentryMan
Copy link
Contributor

@SentryMan SentryMan commented Jan 10, 2025 •
edited
Loading

It seems that it was clashing with the built in avaje inject plugin.

  • excludes avaje inject plugins from the jsonb and validator modules

Resolves #3612

@SentryMan
[Validator] Fix Wiring with Avaje Inject
dcb5ad0 
It seems that it was clashing with the built in avaje inject plugin
@SentryMan SentryMan changed the title [Validator] Fix Wiring with Avaje Inject [Avaje-Validator] Fix Wiring with Avaje Inject Jan 10, 2025
@jknack
Copy link
Member

jknack commented Jan 10, 2025

I'm not sure about the fix. If you put a named service the single lookup won't work anymore. You need:

require(Validator.class, "validator")

or

@Inject(@Named("validator") Validator validator)

right?

@SentryMan SentryMan marked this pull request as draft January 11, 2025 00:14
@SentryMan SentryMan marked this pull request as ready for review January 11, 2025 00:32
@SentryMan
Copy link
Contributor Author

I'm not sure about the fix. If you put a named service the single lookup won't work anymore. You need:

require(Validator.class, "validator")

or

@Inject(@Named("validator") Validator validator)

right?

You wouldn't need the latter, but I did neglect the former in my initial solution. To solve I just exclude the avaje specific inject plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation improvement about usage of Avaje-Inject + Avaje-Validate in Jooby 3.5.5
2 participants
@SentryMan @jknack