Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change submision status or Add submission status of 'Resubmitted' for assignments using attempt until activity is passed #74

Open
biosignalssolutions opened this issue May 2, 2021 · 6 comments

Comments

@biosignalssolutions
Copy link

When auto reopening of attempts until pass is on and submission is made on new 'attempt' and the grade is not pass, status remains as 'Completed' (green) even after student has resubmitted next attempt. Even if student remove the attempt the status remain as Completed. Users (mostly teacher) cannot see where resubmission has been made to previously failed attempt.

It would be great the possibility of a new status, in example a status with color yellow and red cross. That mean task is resumited (o edited) and not passed.

This enhancement maybe adds a new status for this purpose, including a new 'Resubmitted' language string and background colour (with setting).

@superfoght
Copy link

We have the same issue with a client. I can see there is an open PR about the issue. Is this something that will be looked into?

@jonof
Copy link
Owner

jonof commented Dec 9, 2021

... status remains as 'Completed' (green) even after student has resubmitted next attempt ...

What does the course "Activity completion" report say the student's completion state is for the activity? Because keep in mind the block takes its lead from Moodle's completion tracking, and there is very limited embellishment the block does over Moodle's core completion status. The block is not a replacement for Moodle's core completion reporting, nor for individual activities' own status indicators, and it is not in scope for the block to do deep and nuanced inspection or interpretation of the internal state of other activities.

@Ptech676
Copy link

Ptech676 commented Dec 9, 2021

The issue is not when the student have obtained a green but if a student get a red for not completing.
When the student have to opportunity to resubmit the assignment, the block stays red even after resending.
The teacher will have to go trough all the red blocks to see if a student have resend the assignment.

This have been solved in a pull here:
#38
is it possible to implement this

@jonof
Copy link
Owner

jonof commented Dec 9, 2021

As I asked: What does the course "Activity completion" report say the student's completion state is for the activity?

@Ptech676
Copy link

Ptech676 commented Dec 9, 2021

It has a cross.
i have tried to resend the assignment as the student and it changes to yellow so as i can see the plugin works.
Thank you for the best plugin.

@jonof
Copy link
Owner

jonof commented Dec 9, 2021

For reference of others, the logic determining the colour/state of a bar cell is thus:

  1. If Moodle says the activity is "incomplete", but there is a submission, then the cell will show 'submitted' (yellow).
  2. Or if Moodle says the activity is "complete with a failing grade", and there is a submission that is ungraded, then the cell will also show 'submitted' (yellow).
  3. Otherwise, the cell will show what Moodle says the activity's status is:
    • Incomplete but not yet past expected by date = blue.
    • Incomplete and past expected by date = red.
    • Completed = green.
    • Completed but failed = red.
    • Completed and passed = green.

Divination of whether a 'submission' exists and what counts as 'graded' is specially queried only for core Assignment, Workshop, and Quiz activities, because it is reasonably straightforward to do so even though the queries to work that out are grim. Completion Progress relies on activities being sensibly configured, and for other plugins, their code telling the full truth to the Moodle completion system. So if another plugin is lying or leaving out details when it reports completion to Moodle, that should be reported to that plugin's developer because the same lies will be being told in the core 'Activity completion' report.

So, Completion Progress will not implement its own completion logic parallel to what exists in Moodle, nor will it specially work around faulty implementation of completion by other plugins. That was the what predecessor to this block ('Progress') did before the completion system existed and it was nightmarish.

Thank you for the best plugin.

Credit belongs to its creator, Michael de Raadt. I just keep it from breaking as time marches on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants