Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example templates should not be included in package.js by default #49

Open
vladshcherbin opened this issue Feb 22, 2015 · 3 comments
Open
Labels

Comments

@vladshcherbin
Copy link

Correct me if I am wrong, now the form templates come bundled with the forms package. If someone would create custom templates - then what is the point of having default templates for him ?

Maybe it is a good idea to have a skeleton and to move the templates to a different package ?

@jonjamz
Copy link
Owner

jonjamz commented Feb 24, 2015

The templates in the current package are just simple examples to help people get started on their own custom components.

I don't think they should be sourced by default and shipped to the client, but I do think they should exist as part of the core package for convenience.

I plan on moving them into an "examples" folder and will not source them in package.js.

@jonjamz jonjamz changed the title Move default templates to smth like template:forms-templates Example templates should not be included in package.js by default Feb 24, 2015
@jonjamz jonjamz added the v2.0 label Feb 24, 2015
@vladshcherbin
Copy link
Author

I wrote about the package because there may be some lazy or people, who are satisfied with the default ones, so that they can add 2 packages and are ready to go.

sure, examples would be perfect as well

@keithn
Copy link

keithn commented Apr 13, 2015

perhaps the "example" templates should be in their own package? that way you could add example plain, bootstrap, ionic, or whatever you want to demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants