Skip to content

Switch oplog to VecDeque #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jhinch opened this issue Nov 25, 2020 · 1 comment
Closed

Switch oplog to VecDeque #79

jhinch opened this issue Nov 25, 2020 · 1 comment

Comments

@jhinch
Copy link

jhinch commented Nov 25, 2020

Given that the oplog is always added to at the back and drained from the front, it seems like Vec could be switched to a VecDeque. This should improve performance of writes. On my machine it improved the write ops/s for the benchmarks by 20%.
@jonhoo
Copy link
Owner

jonhoo commented Nov 26, 2020

That seems like an excellent idea! I'll work on incorporating that into or right after #73!

@jonhoo jonhoo closed this as completed in ea1fae9 Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonhoo @jhinch