Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancelCompression returns null on Android #271

Open
guy-plentific opened this issue Sep 6, 2024 · 0 comments
Open

cancelCompression returns null on Android #271

guy-plentific opened this issue Sep 6, 2024 · 0 comments

Comments

@guy-plentific
Copy link

The cancelCompression method causes the Future<MediaInfo?> compressVideo() method to resolve to null. On iOS it is resolved as expected to a MediaInfo object with isCancel set to true. The cancelCompression method does seem to cancel the compression operation on both platforms.

I notice there is still a TODO, "Add cancel function to Android" in the package readme, however the change log entry for v2.1.0 states Added cancel compression to android, therefore I'm guessing the TODO was incorrectly left in the readme? This has been tested on both physical Android and iOS devices

To provide consistency between platforms, and match expected behaviour, we would expect the cancelCompression method to cause a running compressVideo to resolve to a MediaInfo object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant