Add array_unique on urls listing #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `castor start`, on some projects, the same url is displayed multiple times, for instance : ``` Available URLs for this project: -------------------------------- * https://foodomarket.local * https://elasticsearch.foodomarket.local * https://kibana.foodomarket.local * https://redis.foodomarket.local * https://foodomarket.local * https://foodomarket.local ```
|
hmm, It would have been better to check why there are the same URL many times! |
|
For the record, it can happen if one of your service is declaring an host matching the "root_domain", f.e. when your frontend service does not use a subdomain. Already got this on a few projects but didn't took time to fix it. |
|
About this issue, my previous comment explained why we listed two times But I just understood that the third repetition of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
castor start, on some projects, the same url is displayed multiple times, for instance :=> "https://foodomarket.local" displayed 3 times