Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Rails 5.2 changes to add_constraints #16

Open
CodingAnarchy opened this issue Jul 9, 2019 · 1 comment
Open

Incompatible with Rails 5.2 changes to add_constraints #16

CodingAnarchy opened this issue Jul 9, 2019 · 1 comment

Comments

@CodingAnarchy
Copy link

It looks like Rails changed how add_constraints works again in Rails 5.2, so in addition to the open PR for ActiveRecord 5.1 support, ActiveRecord 5.2 support will require additional significant changes.

See here: https://github.com/rails/rails/blob/5-2-stable/activerecord/lib/active_record/associations/association_scope.rb#L123

@javierseixas
Copy link

Really interested in these changes... is this gem still being maintained?? 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants