Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to create a new wallet when a previous wallet created and password is forgotten #774

Open
Devinml opened this issue Jun 3, 2024 · 8 comments
Labels
question Further information is requested

Comments

@Devinml
Copy link

Devinml commented Jun 3, 2024

Expected behavior
I should be able to create multiple wallets if I forget the password of a wallet.

Actual behavior
When trying to create a new wallet when the old wallet password was forgotten it routes you to a page that says you must lock your wallet.
image
When "Create new wallet" is pressed I get this screen: Only problem is I don't have the old password to lock the old "test wallet"

image

Steps to reproduce the problem

  1. Create a wallet
  2. Leave it unlocked and try to create a new wallet.

Specifications

  • Version: v0.2.0
  • Platform: umbrel
  • Browser: brave/chrome
@Devinml Devinml added the bug Something isn't working label Jun 3, 2024
@theborakompanioni
Copy link
Collaborator

Hey @Devinml!

Thanks for the report. 🙏

Yes, indeed, that is a problem. However, the password is needed in order to "lock" an active wallet and "unlock" or create/import another one. A possible workaround is to restart the service (e.g. with a system reboot). I do not think there is anything that can be done otherwise (but I might be wrong!).

@editwentyone
Copy link

but lets add this piece of information also:

"… if you have forgot your password, restart the service so that this wallet gets locked and you can proceed."

(bad wording I know)

@theborakompanioni
Copy link
Collaborator

but lets add this piece of information also:

"… if you have forgot your password, restart the service so that this wallet gets locked and you can proceed."

(bad wording I know)

Aww man.. Do you really think that is necessary?
Let's wait at least for an additional report of such a situation before we clutter the UI for such niche situations. Or am I on the wrong track here?

@theborakompanioni
Copy link
Collaborator

What I would do is renaming the active label from "Unlocked" back to what we had earlier: "Active".
(It is strange to unlock something that is already unlocked, is it not?)

@Devinml
Copy link
Author

Devinml commented Jun 3, 2024

As a user I found it confusing, I think there should be an active and then an unlocked.

@theborakompanioni
Copy link
Collaborator

As a user I found it confusing, I think there should be an active and then an unlocked.

Yeah, but that would not really resolve the problem at hand. You need a valid session token to lock or unlock the active wallet in order to create/import a new one. There is only so much you can do, if a user forgets the password. I am afraid, there is nothing we can do about it technically, but at least try to reduce the confusion.

@Devinml
Copy link
Author

Devinml commented Jun 4, 2024

What about adding this to an FAQ section to the readme. I'd be happy to submit that as a pr.

@theborakompanioni theborakompanioni added question Further information is requested and removed bug Something isn't working labels Jun 4, 2024
@theborakompanioni
Copy link
Collaborator

What about adding this to an FAQ section to the readme. I'd be happy to submit that as a pr.

Hey @Devinml, really appreciate your thinking and willingness to help. Thanks brother.
Since this is the first time someone asked, it is not really a "Frequently Asked Question".

Okay for you to wait and see whether other people have a similar issue with this? Thanks again 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants