-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServiceNow link crashes finicky.log() #328
Labels
Comments
sergei-dyshel
added a commit
to sergei-dyshel/finicky
that referenced
this issue
May 15, 2024
Calling `NSLog(message!)` will interpret message as format string (see [docs](https://developer.apple.com/documentation/foundation/1395275-nslog), causing errors and even segfault in some edge cases. Instead, use proper format string and message as argument. Fixes johnste#328.
Happened for me too with other similar long URL. After some debugging and reading, it seems that |
Until pull request is merged, if you don't want to build by yourself, you can use |
Thanks for the build - works perfectly now! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Finicky dies/crashes/immediately exits with a ServiceNow link with logging turned on
Your configuration
To Reproduce
Steps to reproduce the behavior:
I received this link (in Teams, but Finicky crashes no matter how I try to open it):
https://borderstates.service-now.com/nav_to.do?uri=%2Fincident.do%3Fsys_id%3Dec58338d470e4650d3b39d75536d4314%26sysparm_record_target%3Dtask%26sysparm_record_row%3D7%26sysparm_record_rows%3D11%26sysparm_record_list%3Dassigned_to%3D821397091bab09103baa64e8bc4bcbbf%5EstateNOT%2BIN3,4,7,6%5Esys_class_name%3Dincident%5EORDERBYpriority%5EORDERBYnumber
Clicking on it in Teams or copying the URL and trying to "open" it from the terminal crashes Finicky.
If I comment out the "finicky.log" line in my .finicky.js file, then it works fine.
Here's one of the crash files I got:
Finicky-2024-05-13-094003.ips.txt
The text was updated successfully, but these errors were encountered: