Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing -interposable linker warning doesn't take into account xcconfig files #534

Open
clemzio opened this issue Jan 25, 2025 · 2 comments

Comments

@clemzio
Copy link

clemzio commented Jan 25, 2025

Hey there, thanks for building this!

This is a super minor issue but I noticed that I'm constantly getting the following warning in my console:

💉 ⚠️ Project file /Users/[redacted]/[redacted].xcodeproj does not contain the -interposable linker flag. In order to be able to inject methods of structs and final classes, please add "Other Linker Flags" -Xlinker -interposable for Debug builds only.

However I do actually set those flags but via an xcconfig instead (and the reloading works as expected).

// Hot-reloading with Inject.
OTHER_LDFLAGS = $(inherited) -Xlinker -interposable
Image

Reproduced with HotSwiftUI 1.2.0

@johnno1962
Copy link
Owner

Ah, there isn't much I can do about that if it's in an .xcconfig. It's important people set the -interposable flag so I'd rather err on the side of reporting it.

@clemzio
Copy link
Author

clemzio commented Jan 28, 2025

@johnno1962 thanks for the quick answer and I totally understand your reasoning. As a potential compromise, would it make sense to have an optional way to disable this warning (and/or opt-out of the check)?
Otherwise feel free to close! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants