Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting gzip decompression #177

Open
shobhitpuri opened this issue Jun 9, 2015 · 0 comments
Open

Supporting gzip decompression #177

shobhitpuri opened this issue Jun 9, 2015 · 0 comments

Comments

@shobhitpuri
Copy link

Hi

Thanks for the awesome library. I was wondering that should the support for GZIP decompression be added to master? I could see in the "experimental" branch that a commit has been made regarding supporting GZIP decompression: d858de6. However that branch is too old and does not support running 64bit. When I run on XCode, it gives depreciation errors like:

JSONKit.m:2731:31: error: direct access to Objective-C's isa is deprecated in favor of 
object_getClass()   [-Werror,-Wdeprecated-objc-isa-usage] 
if(JK_EXPECT_T(object->isa == encodeState->fastClassLookup.stringClass))     {
             isClass = JKClassString;    
 }
 31: Direct access to Objective-C's isa is deprecated in favor of object_getClass()
 3: Expanded from macro 'JK_EXPECT_T'
 5: Expanded from macro 'JK_EXPECTED'

The master branch which supports running on 64bit architectures doesn't have the above commit related to gzip. Since a lot has changed since then, cherry picking the specific commit from the experimental branch to master is giving lots of conflicts. Can anyone please give a direction as to how can gzip decompression be supported?

Thanks so much.
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant