-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tesla internship validation issue #100
Comments
I know why this is happening. When the regex tries to pull the period and year out of the title, it falls back to the entire title. It should fall back to an empty string or None/null. I was having trouble specifying an empty string or None/null as the default value for the regex when I was finalizing the big add websites PR. Pydantic doesn't make a meaningful distinction between a non-existent value, an empty value, and a null value in the config, so I tried to write a custom validator for it. Unfortunately, Pydantic validators are unintuitive. It appears that the current config validation is not working correctly. |
Hopefully this will be solved with #136 , so I might hold off on completing this ticket until we get that implemented |
Does this run config work: |
With the new backend, this issue will (hopefully) go away! |
Context
I've noticed that when scraping Tesla, some invalid attributes get written to the db. Sometimes, the Tesla internship
title
gets put into theperiod
andyear
. See image below.TODO
Notes
The text was updated successfully, but these errors were encountered: