Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Semantic Markup #44

Open
mattkaye opened this issue Sep 30, 2024 · 1 comment
Open

Improvement: Semantic Markup #44

mattkaye opened this issue Sep 30, 2024 · 1 comment

Comments

@mattkaye
Copy link

mattkaye commented Sep 30, 2024

This is really nice and easy to use but why did you use a series of divs to output the nav? It would be better to use <ul> and series of <li> tags. Just a thought. Nice work and thanks!

@johndatserakis
Copy link
Owner

Hey there - good question and fair point. I paid special attention to a11y in this lib, but looking back, not using ul's and li's for the nav list items was probably an oversight. In the past I felt like those elements were too restrictive when styling, but I don't think that would be difficult to overcome in all honesty (really the concern would be the default styling by some browsers on those elements, but it should be managable).

Anyways, I've short on time right now and I don't think this is something I'd be able to get to properly at the moment, especially considering the styling changes that would be needed to be accounted for and checked. Regardless, thanks for raising, this is an important thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants