You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is really nice and easy to use but why did you use a series of divs to output the nav? It would be better to use <ul> and series of <li> tags. Just a thought. Nice work and thanks!
The text was updated successfully, but these errors were encountered:
Hey there - good question and fair point. I paid special attention to a11y in this lib, but looking back, not using ul's and li's for the nav list items was probably an oversight. In the past I felt like those elements were too restrictive when styling, but I don't think that would be difficult to overcome in all honesty (really the concern would be the default styling by some browsers on those elements, but it should be managable).
Anyways, I've short on time right now and I don't think this is something I'd be able to get to properly at the moment, especially considering the styling changes that would be needed to be accounted for and checked. Regardless, thanks for raising, this is an important thing.
This is really nice and easy to use but why did you use a series of divs to output the nav? It would be better to use
<ul>
and series of<li>
tags. Just a thought. Nice work and thanks!The text was updated successfully, but these errors were encountered: