Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please change file and directory names with spaces in it (such as "Super Productivty") to spaceless ("SuperProductivity") #3787

Open
freedio opened this issue Dec 21, 2024 · 4 comments

Comments

@freedio
Copy link

freedio commented Dec 21, 2024

I had troubles running the last (which was also my first) update of SuperProductivity built from sources on my Ubuntu Linux box:

$ superproductivity 
LaunchProcess: failed to execvp:
/opt/Super
[6986:1221/114546.354549:FATAL:zygote_host_impl_linux.cc(207)] Check failed: . : Invalid argument (22)
Trace/breakpoint trap (core dumped)

↑ You can see on the third line above that the directory name was cut off at the space, and so the software couldn't be found anymore.

When I changed the directory to SuperProductivity and adjusted the link in /etc/alternatives, everything started working fine (except the Sync complained about an old profile).

You could maybe also fix this by inserting a backslash before the space, or by quoting the whole path, but I recommend to just eliminate the space, because it's non-standard and absolutely not necessary (I would write superproductivity exacly like that, or with a dash, which would also work with a file name.

Copy link

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

Copy link

Hello there freedio! 👋

Thank you and congratulations 🎉 for opening your very first issue in this project! 💖

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀

For more open ended discussions and/or specific questions, please visit the discussions page. 💖

@johannesjo
Copy link
Owner

How are you building the app? There are not really any folders that have a space in them. Possibly they're getting created when building with electron builder, but then there is not much we can do about it.

@freedio
Copy link
Author

freedio commented Dec 22, 2024

The process was a bit messy, but I used npm only (npm install, npm run build, npm run package, npm run localInstall), and I don't remember which command eventually installed the software in /opt/Super Productivity, but from lastModified, it is clear that the old version was overwritten. It was unbeknownst to me in the beginning that the binary is actually called via /usr/bin/superrproductivity → /etc/alternatives/productivity → /opt/Super Productivity/superproductivity.

Btw, the old version was probably installed through a .deb-Package, but I didn't find a .deb-Package for the new version, so I decided to do it the hard way, because I banned snap from my system for various reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants