Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags should not match spaces or generally be less sensitive to hashtags being used #2856

Closed
rklec opened this issue Nov 17, 2023 · 4 comments

Comments

@rklec
Copy link
Contributor

rklec commented Nov 17, 2023

I wanted to make a task out of a Pluralsight title course, but this course contained the word C# which caused it to interpret everything following the hashtag as a tag.

Your Environment

  • Version used: 7.1.4.3 from Windows Installer
  • Operating System and version: Windows 10
  • Desktop Environment: N/A
  • Browser Name and version: N/A

Expected Behavior

Making Your C# 7 Code More Functional

It creates the tag "7 Code More Functional" on the task "Making Your C", which is quite fun, but not what I want.

grafik

Note it does this **even though" there is a space after the sharp (#) sign!

Current Behavior

grafik
grafik

Steps to Reproduce (for bugs)

Copy "Making Your C# 7 Code More Functional" (maybe the HTML formatting matters, but I doubt it)

grafik
grafik

Can you reproduce this reliably?

Yes.
Reproducible.

Console Output

action-logger.reducer.ts:11 [Layout] Show AddTaskBar {type: '[Layout] Show AddTaskBar'}
action-logger.reducer.ts:11 [Task][Issue] Add Task {task: {…}, workContextId: 'uzWenZ18BHBh29v8tgq7h', workContextType: 'PROJECT', isAddToBacklog: false, isAddToBottom: false, …}isAddToBacklog: falseisAddToBottom: falsetask: {id: 'GjzCMSpXqcHeCHZc8GrBB', projectId: 'uzWenZ18BHBh29v8tgq7h', subTaskIds: Array(0), timeSpentOnDay: {…}, timeSpent: 0, …}type: "[Task][Issue] Add Task"workContextId: "uzWenZ18BHBh29v8tgq7h"workContextType: "PROJECT"[[Prototype]]: Object
task-related-model.effects.ts:193 shortSyntax {taskChanges: {…}, newTagTitles: Array(0), remindAt: null, projectId: undefined}newTagTitles: []projectId: undefinedremindAt: nulltaskChanges: {tagIds: Array(1), title: 'Making Your C'}[[Prototype]]: Object
action-logger.reducer.ts:11 [Persistence] Save to DB {dbKey: 'project', data: {…}, type: '[Persistence] Save to DB'}
action-logger.reducer.ts:11 [Persistence] Save to DB {dbKey: 'task', data: {…}, type: '[Persistence] Save to DB'}
action-logger.reducer.ts:11 [Task] Update Task {task: {…}, type: '[Task] Update Task'}
action-logger.reducer.ts:11 [Task] Update Task Tags {task: {…}, newTagIds: Array(1), oldTagIds: Array(0), type: '[Task] Update Task Tags'}
action-logger.reducer.ts:11 [Persistence] Save to DB {dbKey: 'task', data: {…}, type: '[Persistence] Save to DB'}
action-logger.reducer.ts:11 [Persistence] Save to DB {dbKey: 'tag', data: {…}, type: '[Persistence] Save to DB'}
action-logger.reducer.ts:11 [Persistence] Save to DB {dbKey: 'task', data: {…}, type: '[Persistence] Save to DB'}
action-logger.reducer.ts:11 [Layout] Hide AddTaskBar {type: '[Layout] Hide AddTaskBar'}type: "[Layout] Hide AddTaskBar"[[Prototype]]: Object
persistence.service.ts:338 LOAD COMPLETE false
model-version.ts:36 [M] Migrating model "GlobalConfig" to version from 2.203 to 2.303 {lang: {…}, misc: {…}, evaluation: {…}, idle: {…}, takeABreak: {…}, …}
migrate-global-config.util.ts:113 EXTEND globalConfig sound breakReminderSound null

Nothing relevant though.

Error Log (Desktop only)

nothing relevant

@rklec rklec added the bug label Nov 17, 2023
Copy link

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

@rklec
Copy link
Contributor Author

rklec commented Nov 17, 2023

Weird enough (but maybe good in my use case), if the tag is already created, it does not recreate it. Even if you then remove it, it seems to keep it now hmm...

@KatrinIhler
Copy link

Seconded! I'm always surprised when I paste a URL containing a # and the latter half of it just decides to be a tag instead. :D

Also the possibility to escape a # to circumvent this behavior would be great. I sometimes reference issue numbers with #, which works well if it's the very first thing in the task title, but not if there's anything in front of it. I think I could get into the habit of escaping if such a thing existed...

@Jagdfalke
Copy link
Collaborator

The current version 8.0.1 handles tags more sensible. The above given sample text will not create a new tag anymore.

Additionally, whenever a new tag is supposed to be created, Super Productivity will prompt you whether a new tag should be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants