Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow easier configuration of compile-time settings #291

Open
WesleyAC opened this issue Sep 28, 2023 · 0 comments
Open

Allow easier configuration of compile-time settings #291

WesleyAC opened this issue Sep 28, 2023 · 0 comments

Comments

@WesleyAC
Copy link
Collaborator

Currently, compile-time changes seem to be done by either changing the code, or with #defines in individual faces. This means that making changes to constants requires doing a git merge when updating the firmware. Instead, I'd like to see a file just for user preferences that could be kept outside of version control for changing constants. (or perhaps these could be set in the movement_config.h, since that's currently where I would expect most users to start their customization).

I would imagine this looking like a extremely simple macro or two, maybe as simple as a DEFINE_CONSTANT(name, default) that is just a #ifndef / #define / #endif, where the user's configuration file is loaded before watch faces. I think most of the value is just in having a standard way of doing this across faces, the implementation is pretty trivial.

Thoughts? Perhaps related to #70, although that is somewhat different and fancier, I think probably we want to solve this issue and that one separately.

matheusmoreira added a commit to matheusmoreira/sensor-watch that referenced this issue Mar 5, 2024
Adds overridable C preprocessor definitions for every user preference.
Enables the user to set defaults and omit the preferences face.

The default behavior of the watch is preserved.

Suggested-by: Wesley Aptekar-Cassels <[email protected]>
Implemented-by: madhogs <[email protected]>
Reviewed-by: Matheus Afonso Martins Moreira <[email protected]>
Signed-off-by: Matheus Afonso Martins Moreira <[email protected]>
GitHub-Pull-Request: joeycastillo#295
GitHub-Related-Issue: joeycastillo#291
matheusmoreira added a commit to matheusmoreira/sensor-watch that referenced this issue Mar 5, 2024
Adds overridable C preprocessor definitions for every user preference.
Enables the user to set defaults and omit the preferences face.

The default behavior of the watch is preserved.

Suggested-by: Wesley Aptekar-Cassels <[email protected]>
Implemented-by: madhogs <[email protected]>
Reviewed-by: Matheus Afonso Martins Moreira <[email protected]>
Signed-off-by: Matheus Afonso Martins Moreira <[email protected]>
GitHub-Pull-Request: joeycastillo#295
GitHub-Related-Issue: joeycastillo#291
matheusmoreira added a commit to matheusmoreira/sensor-watch that referenced this issue Mar 5, 2024
Adds overridable C preprocessor definitions for every user preference.
Enables the user to set defaults and omit the preferences face.

The default behavior of the watch is preserved.

Suggested-by: Wesley Aptekar-Cassels <[email protected]>
Implemented-by: madhogs <[email protected]>
Reviewed-by: Matheus Afonso Martins Moreira <[email protected]>
Signed-off-by: Matheus Afonso Martins Moreira <[email protected]>
GitHub-Pull-Request: joeycastillo#295
GitHub-Related-Issue: joeycastillo#291
matheusmoreira added a commit to matheusmoreira/sensor-watch that referenced this issue Mar 5, 2024
Adds overridable C preprocessor definitions for every user preference.
Enables the user to set defaults and omit the preferences face.

The default behavior of the watch is preserved.

Suggested-by: Wesley Aptekar-Cassels <[email protected]>
Implemented-by: madhogs <[email protected]>
Reviewed-by: Matheus Afonso Martins Moreira <[email protected]>
Signed-off-by: Matheus Afonso Martins Moreira <[email protected]>
GitHub-Pull-Request: joeycastillo#295
GitHub-Related-Issue: joeycastillo#291
matheusmoreira added a commit to matheusmoreira/sensor-watch that referenced this issue Mar 8, 2024
Adds overridable C preprocessor definitions for every user preference.
Enables the user to set defaults and omit the preferences face.

The default behavior of the watch is preserved.

Suggested-by: Wesley Aptekar-Cassels <[email protected]>
Implemented-by: madhogs <[email protected]>
Reviewed-by: Matheus Afonso Martins Moreira <[email protected]>
Tested-by: Matheus Afonso Martins Moreira <[email protected]>
Tested-on-hardware-by: Matheus Afonso Martins Moreira <[email protected]>
Signed-off-by: Matheus Afonso Martins Moreira <[email protected]>
GitHub-Pull-Request: joeycastillo#295
GitHub-Related-Issue: joeycastillo#291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant