Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion between eras with NA units #29

Open
joeroe opened this issue Jan 26, 2021 · 0 comments
Open

Conversion between eras with NA units #29

joeroe opened this issue Jan 26, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@joeroe
Copy link
Owner

joeroe commented Jan 26, 2021

yr_transform() currently throws an error if either the source or destination era has an NA unit, following the R convention that NA == NA is NA.

It might not be necessary to be this strict, for example to allow transformations between era("bp") and era("bce"), and just warn that there is an assumption that the units are comparable.
@joeroe joeroe added the enhancement New feature or request label Jan 26, 2021
@joeroe joeroe added this to the v1.0 milestone Jan 26, 2021
@joeroe joeroe modified the milestones: 1.0.0, 0.4.0 Feb 7, 2021
@joeroe joeroe modified the milestones: 0.4.0, 1.0.0 Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@joeroe