Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cal summary functions ignore era #4

Open
joeroe opened this issue Oct 1, 2020 · 1 comment
Open

cal summary functions ignore era #4

joeroe opened this issue Oct 1, 2020 · 1 comment
Milestone

Comments

@joeroe
Copy link
Owner

joeroe commented Oct 1, 2020

min.cal and max.cal both assume that the object passed to them uses BP-like years, i.e. min returns max(year) and max returns min(year). This is confusing if they're used on dates with a CE-based era or negative BCE/BP years.

These and other functions should take into account the era attribute of cal objects.

@joeroe joeroe transferred this issue from joeroe/stratigraphr Jan 30, 2021
@joeroe
Copy link
Owner Author

joeroe commented Oct 17, 2024

I think what should happen here is:

  • min.cal() and max.cal() should behave like the base versions, i.e. return the numerical min and max
  • era should provide yr_earliest() and yr_latest() that responds to the direction of the era
  • c14 should provide cal_age_range() that uses yr_earliest() and yr_latest()

@joeroe joeroe added this to the v0.1 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant