Hide sync library by default #1203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hide sync library from overflow if sync feature is not used
jobobby04
requested changes
Jun 26, 2024
| @@ -107,6 +110,7 @@ private fun LibraryRegularToolbar( | |||
| searchQuery = searchQuery, | |||
| onChangeSearchQuery = onSearchQueryChange, | |||
| actions = { | |||
| val syncPreferences: SyncPreferences = Injekt.get() // SY | |||
There was a problem hiding this comment.
The syncPreferences.isSyncEnabled() needs to be a state thats stored inside the LibraryScreenModel and passed through a parameter. We can't have it inside the composable
|
Superseded by #1275 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only show "Sync library" in library overflow if sync feature is not off