Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delphi AVX enhancements #88

Open
mikerabat opened this issue May 13, 2022 · 6 comments
Open

Delphi AVX enhancements #88

mikerabat opened this issue May 13, 2022 · 6 comments

Comments

@mikerabat
Copy link

This request would be twofold...
First it would be great if there are AVX functions for the Delphi community too. I actually started to implement the DotProduct for
Delphi2010 and upwards but I have no clue how to get that back to you.

The second suggestion is to get rid of the AVX defines and let the class decide which path would be the fastest to use.
E.g. the unit I wrote once on https://github.com/mikerabat/mrmath/blob/master/CPUFeatures.pas is perfectly suited for that ;)

Let me know what you think of this idea.

@joaopauloschuler
Copy link
Owner

I like having IFDEFS...

I'll probably be too busy to code AVX support on Delphi for the next 7 months. Open source code can always be forked... With the proper IFDEFs, it could work.

@mikerabat
Copy link
Author

If you are interested in that I can provide you Delphi units and contribute a bit to your great work. Actually I already created one that computes the dot product (as far as I can see the working horse...) for Delphi 32 and 64 bit (+Unix ABI).

And... these units include A LOT of Ifdefs ;) :D

mikerabat added a commit to mikerabat/neural-api that referenced this issue Aug 1, 2022
joaopauloschuler#85: Fixed opencl problem

+ Better cloning (way faster)
+ Fixed many Delphi warnings
+ New convolutional classes with swift and gelu
+ Automatic check if AVX is available
+ Fixed issues with output procedures: sometimes error proc pointed to the console output (althouth I wanted that in a file...)
@mikerabat
Copy link
Author

I actually managed to fork the repository and add the Delphi AVX enhancements... though I wasn't able to create a pull request...

anyway if you are interested in the changes check out:
https://github.com/mikerabat/neural-api

@joaopauloschuler
Copy link
Owner

@mikerabat , I'm certainly interested. I'll try to figure why the pull request didn't work.

@joaopauloschuler
Copy link
Owner

@mikerabat , I can see plenty of coding. It will take me some time to test it in all supported environments. Most likely, I'll ask you to create a new branch with smaller commits that are easier to merge. We'll see. I'll FUP in few months from now.

@mikerabat
Copy link
Author

sure thing :) I'll try my best to help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants