Skip to content

Commit 462c5b5

Browse files
committed
drop long-deprecated check_version() function
1 parent 87dcd8c commit 462c5b5

File tree

4 files changed

+6
-20
lines changed

4 files changed

+6
-20
lines changed

pulse-binding/CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
* Added `to_owned()` methods to a bunch of objects like `SinkInfo` (as requested back in 2021 in
44
issue 44). Thanks to @t4ccer on github for prompting this and providing an initial partial
55
implementation.
6+
* Dropped additional long-deprecated constants, missed in the previous version.
7+
* Dropped long-deprecated `check_version()` function.
68

79
# 2.29.0 (March 3rd, 2025)
810

pulse-binding/src/version.rs

-10
Original file line numberDiff line numberDiff line change
@@ -166,16 +166,6 @@ pub fn get_library_version() -> &'static CStr {
166166
unsafe { CStr::from_ptr(capi::pa_get_library_version()) }
167167
}
168168

169-
/// Just compares given version with that defined in `TARGET_VERSION` and returns `true` if the
170-
/// `TARGET_VERSION` version is greater. This does **not** involve talking to the PulseAudio client
171-
/// library at runtime. This is not very useful!
172-
#[deprecated(since = "2.22.0")]
173-
#[inline(always)]
174-
pub fn check_version(major: u8, minor: u8, micro: u8) -> bool {
175-
#[allow(deprecated)]
176-
capi::pa_check_version(major, minor, micro)
177-
}
178-
179169
#[test]
180170
fn test_ver_str_to_num() {
181171
assert_eq!(pa_version_str_to_num(""), Err(ErrorKind::ParseIntError));

pulse-sys/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# <unreleased>
2+
3+
* Dropped long-deprecated `pa_check_version()` function.
4+
15
# 1.22.0 (March 3rd, 2025)
26

37
* Bumped MSRV from 1.56 to 1.63 per libc dependency.

pulse-sys/src/version.rs

-10
Original file line numberDiff line numberDiff line change
@@ -165,16 +165,6 @@ pub const fn get_compatibility() -> Compatibility {
165165
actual::COMPATIBILITY
166166
}
167167

168-
/// Just compares given version with that defined in `TARGET_VERSION` and returns `true` if the
169-
/// `TARGET_VERSION` version is greater. This does **not** involve talking to the PulseAudio client
170-
/// library at runtime. This is not very useful!
171-
#[deprecated(since = "1.17.0")]
172-
#[inline(always)]
173-
pub const fn pa_check_version(major: u8, minor: u8, _micro: u8) -> bool {
174-
// Note, defined micro version is always zero as of PA v1.0, thus ignored here
175-
(TARGET_VERSION.0 > major) || ((TARGET_VERSION.0 == major) && (TARGET_VERSION.1 > minor))
176-
}
177-
178168
#[link(name = "pulse")]
179169
extern "C" {
180170
pub fn pa_get_library_version() -> *const c_char;

0 commit comments

Comments
 (0)