Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: function correct_labels does not exist in the codebase, console entry point broken #31

Open
GenevieveBuckley opened this issue May 11, 2022 · 4 comments

Comments

@GenevieveBuckley
Copy link
Contributor

The console entry point refers to zarpaint._main:main, but this produces an error. You cannot run the main function here because it tries to execute a function correct_labels that doesn't exist anywhere in the codebase. (I think it's been partially refactored, causing this issue).

@GenevieveBuckley
Copy link
Contributor Author

Perhaps it should be create_labels instead?

@jamesyan-git
Copy link
Contributor

Hi @GenevieveBuckley ,

I had a look at the history, and based on these two commits , I think the CLI usage is deprecated and been replaced with the command listed here .

Looks like the rest of the functionality in LabelCorrector has been split up into the different widgets of the plugin? @jni I think we should be removing _main.py and LabelCorrector entirely but can you please confirm. If there is functionality in there that we want to keep please let me know.

@GenevieveBuckley
Copy link
Contributor Author

Thanks for looking into it!

@jni
Copy link
Owner

jni commented Aug 9, 2022

I can confirm your interpretation @jamesyan-git! Thanks for looking into it! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants