New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EncodeUri() if part of the URL path or EncodeUriComponent() if used as a URL parameter #1

Open

philpott opened this issue Mar 16, 2022 · 0 comments

philpott commented Mar 16, 2022

ot-cmp-gcm-template/template.tpl

Line 143 in 94c333a

    
           let scriptURL ='https://' + data.URL + '/scripttemplates/otSDKStub.js?did='+ data.Domain;

When reviewing your template we've noticed that it is using parameters to build a url. It's a best practice to use [EncodeUri()](https://developers.google.com/tag-manager/templates/api#encodeuri) if part of the URL path or [EncodeUriComponent()](https://developers.google.com/tag-manager/templates/api#encodeuricomponent) if used as a URL parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment