Skip to content

Commit b8e36d4

Browse files
Align env variables for OTLP ports (open-telemetry#1353)
* Align env variables for OTLP ports. No functional changes. * Add CHANGELOG --------- Co-authored-by: Juliano Costa <[email protected]>
1 parent 22dc002 commit b8e36d4

File tree

3 files changed

+14
-12
lines changed

3 files changed

+14
-12
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ the release.
3838
([#1352](https://github.com/open-telemetry/opentelemetry-demo/pull/1352))
3939
* [kafka] Major version update for Java instrumentation, version 2.0.0
4040
([#1352](https://github.com/open-telemetry/opentelemetry-demo/pull/1352))
41+
* Align env variables for OTLP ports
42+
([#1353](https://github.com/open-telemetry/opentelemetry-demo/pull/1353))
4143

4244
## 1.7.2
4345

docker-compose.minimal.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ services:
166166
environment:
167167
- APP_ENV=production
168168
- EMAIL_SERVICE_PORT
169-
- OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://${OTEL_COLLECTOR_HOST}:4318/v1/traces
169+
- OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://${OTEL_COLLECTOR_HOST}:${OTEL_COLLECTOR_PORT_HTTP}/v1/traces
170170
- OTEL_RESOURCE_ATTRIBUTES
171171
- OTEL_SERVICE_NAME=emailservice
172172
depends_on:
@@ -371,7 +371,7 @@ services:
371371
ports:
372372
- "${QUOTE_SERVICE_PORT}"
373373
environment:
374-
- OTEL_EXPORTER_OTLP_ENDPOINT=http://${OTEL_COLLECTOR_HOST}:4318
374+
- OTEL_EXPORTER_OTLP_ENDPOINT=http://${OTEL_COLLECTOR_HOST}:${OTEL_COLLECTOR_PORT_HTTP}
375375
- OTEL_PHP_AUTOLOAD_ENABLED=true
376376
- QUOTE_SERVICE_PORT
377377
- OTEL_RESOURCE_ATTRIBUTES
@@ -433,7 +433,7 @@ services:
433433
environment:
434434
- SHIPPING_SERVICE_PORT
435435
- QUOTE_SERVICE_ADDR
436-
- OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://${OTEL_COLLECTOR_HOST}:4317/v1/traces
436+
- OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://${OTEL_COLLECTOR_HOST}:${OTEL_COLLECTOR_PORT_GRPC}/v1/traces
437437
- OTEL_RESOURCE_ATTRIBUTES
438438
- OTEL_SERVICE_NAME=shippingservice
439439
depends_on:
@@ -479,7 +479,7 @@ services:
479479
restart: unless-stopped
480480
ports:
481481
- "${JAEGER_SERVICE_PORT}" # Jaeger UI
482-
- "4317" # OTLP gRPC default port
482+
- "${OTEL_COLLECTOR_PORT_GRPC}"
483483
environment:
484484
- METRICS_STORAGE_TYPE=prometheus
485485
logging: *logging
@@ -515,8 +515,8 @@ services:
515515
- ./src/otelcollector/otelcol-config.yml:/etc/otelcol-config.yml
516516
- ./src/otelcollector/otelcol-config-extras.yml:/etc/otelcol-config-extras.yml
517517
ports:
518-
- "4317" # OTLP over gRPC receiver
519-
- "4318" # OTLP over HTTP receiver
518+
- "${OTEL_COLLECTOR_PORT_GRPC}"
519+
- "${OTEL_COLLECTOR_PORT_HTTP}"
520520
depends_on:
521521
- jaeger
522522
logging: *logging

docker-compose.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ services:
197197
environment:
198198
- APP_ENV=production
199199
- EMAIL_SERVICE_PORT
200-
- OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://${OTEL_COLLECTOR_HOST}:4318/v1/traces
200+
- OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://${OTEL_COLLECTOR_HOST}:${OTEL_COLLECTOR_PORT_HTTP}/v1/traces
201201
- OTEL_RESOURCE_ATTRIBUTES
202202
- OTEL_SERVICE_NAME=emailservice
203203
depends_on:
@@ -465,7 +465,7 @@ services:
465465
ports:
466466
- "${QUOTE_SERVICE_PORT}"
467467
environment:
468-
- OTEL_EXPORTER_OTLP_ENDPOINT=http://${OTEL_COLLECTOR_HOST}:4318
468+
- OTEL_EXPORTER_OTLP_ENDPOINT=http://${OTEL_COLLECTOR_HOST}:${OTEL_COLLECTOR_PORT_HTTP}
469469
- OTEL_PHP_AUTOLOAD_ENABLED=true
470470
- QUOTE_SERVICE_PORT
471471
- OTEL_RESOURCE_ATTRIBUTES
@@ -530,7 +530,7 @@ services:
530530
environment:
531531
- SHIPPING_SERVICE_PORT
532532
- QUOTE_SERVICE_ADDR
533-
- OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://${OTEL_COLLECTOR_HOST}:4317/v1/traces
533+
- OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://${OTEL_COLLECTOR_HOST}:${OTEL_COLLECTOR_PORT_GRPC}/v1/traces
534534
- OTEL_RESOURCE_ATTRIBUTES
535535
- OTEL_SERVICE_NAME=shippingservice
536536
depends_on:
@@ -632,7 +632,7 @@ services:
632632
restart: unless-stopped
633633
ports:
634634
- "${JAEGER_SERVICE_PORT}" # Jaeger UI
635-
- "4317" # OTLP gRPC default port
635+
- "${OTEL_COLLECTOR_PORT_GRPC}"
636636
environment:
637637
- METRICS_STORAGE_TYPE=prometheus
638638
logging: *logging
@@ -668,8 +668,8 @@ services:
668668
- ./src/otelcollector/otelcol-config.yml:/etc/otelcol-config.yml
669669
- ./src/otelcollector/otelcol-config-extras.yml:/etc/otelcol-config-extras.yml
670670
ports:
671-
- "4317" # OTLP over gRPC receiver
672-
- "4318" # OTLP over HTTP receiver
671+
- "${OTEL_COLLECTOR_PORT_GRPC}"
672+
- "${OTEL_COLLECTOR_PORT_HTTP}"
673673
depends_on:
674674
- jaeger
675675
logging: *logging

0 commit comments

Comments
 (0)