Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delay reload run if last command exited with a bad status #16

Open
jmhodges opened this issue May 5, 2017 · 1 comment
Open

delay reload run if last command exited with a bad status #16

jmhodges opened this issue May 5, 2017 · 1 comment

Comments

@jmhodges
Copy link
Owner

jmhodges commented May 5, 2017

No description provided.

@jmhodges
Copy link
Owner Author

jmhodges commented May 5, 2017

This will need Reload to return an error only from cmd.Start or if a cs.waitChan() returns a non-nil error. The waitChan part is tricky because it's intentionally private because if we allowed reloads to happen while the waitChan goroutine was running, we might get bad data.

Actually, we might be able to add a method that just checks if waitErr != nil when a watcher event coming over cmdCh to see if it should wait a bit longer by using similar code to what's there now to delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant