Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: re-throw error in default serviceErrorHandler #1153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: re-throw error in default serviceErrorHandler #1153

wants to merge 1 commit into from

Conversation

SystemDisc
Copy link

@SystemDisc SystemDisc commented Jul 15, 2024 •
edited
Loading

This makes errors bubble up to await CommandFactory.run(...); like they should.

Example code utilizing new behavior:

import { CommandFactory } from 'nest-commander';
import { CommanderModule } from './commander.module';

async function bootstrap() {
  try {
    await CommandFactory.run(CommanderModule, ['verbose', 'debug', 'log', 'warn', 'error']);
  } catch (e) {
    process.exit(1);
  }
}

bootstrap();

@SystemDisc
feat: re-throw error in default serviceErrorHandler
e04a5ea 
This makes errors bubble up to `await CommandFactory.run(...);` like they should
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2024

⚠️ No Changeset found

Latest commit: e04a5ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alburkerk
Copy link

This should be merged.

Currently it make all scripts fails silently which is a big issue

@jmcdo29
Copy link
Owner

jmcdo29 commented Oct 22, 2024

@SystemDisc can you resolve the conflicts and add a changeset by following pnpm changeset? This should be a patch. With that, I'll get this merged and released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SystemDisc @alburkerk @jmcdo29