Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoboBrowser is broken with werkzeug upgrade #93

Open
TijanaJakovljevic opened this issue Feb 10, 2020 · 4 comments
Open

RoboBrowser is broken with werkzeug upgrade #93

TijanaJakovljevic opened this issue Feb 10, 2020 · 4 comments

Comments

@TijanaJakovljevic
Copy link

TijanaJakovljevic commented Feb 10, 2020 •
edited
Loading

werkzeug is upgraded to 1.0.0 and RoboBrowser is broken with this change.

Traceback (most recent call last):
     from robobrowser import RoboBrowser
   File "/home/ubuntu/venv/lib/python3.7/site-packages/robobrowser/__init__.py", line 3, in <module>
     from .browser import RoboBrowser
   File "/home/ubuntu/venv/lib/python3.7/site-packages/robobrowser/browser.py", line 8, in <module>
     from werkzeug import cached_property
 ImportError: cannot import name 'cached_property' from 'werkzeug' (/home/ubuntu/venv/lib/python3.7/site-packages/werkzeug/__init__.py)

It’s because cached_property has to be explicitly imported from werkzeug.utils now
'from werkzeug.utils import cached_property' should be used instead 'from werkzeug import cached_property'
@H3wastooshort
Copy link

made it a prq @ #97

@beaufour beaufour mentioned this issue Apr 8, 2020
Closed
@manishmaharjan
Copy link

manishmaharjan commented Jun 27, 2020 •
edited
Loading

I had a similar issue.

import werkzeug
werkzeug.cached_property = werkzeug.utils.cached_property

adding this before import robobrowser solved the issue for me

@sundios sundios mentioned this issue Jul 2, 2020
Closed
@j4nr6n j4nr6n mentioned this issue Jul 13, 2020
Closed
@lovetoburnswhen
Copy link

I had a similar issue.

import werkzeug
werkzeug.cached_property = werkzeug.utils.cached_property

adding this before import robobrowser solved the issue for me

Worked for me as well thanks

antoni-g added a commit to antoni-g/robobrowser that referenced this issue Sep 10, 2020
@antoni-g
Update browser.py
b01fe0e 
Werkzeug was upgraded to 1.0.0 and introduced this error:
```ImportError: cannot import name 'cached_property' from 'werkzeug' (/usr/local/lib/python3.8/site-packages/werkzeug/__init__.py)```

Suggesting this change which has been tested locally and discussed here:
jmcarp#93
@antoni-g antoni-g mentioned this issue Sep 10, 2020
Open
89Q12 added a commit to 89Q12/moodle_scrapping_discord_bot that referenced this issue Jan 29, 2021
@89Q12
Fixed failed import of cached_property
390317c 
Fixes this issue in the robobrowser jmcarp/robobrowser#93
@BachoSeven BachoSeven mentioned this issue Mar 28, 2021
Closed
@BachoSeven BachoSeven mentioned this issue Apr 4, 2021
Closed
benwinding added a commit to benwinding/myuni-dl that referenced this issue Jun 14, 2021
@benwinding
Fixes #1
a36dd24 
Implemented fix from: jmcarp/robobrowser#93 (comment)
@benwinding benwinding mentioned this issue Jun 14, 2021
Closed
@Swastik1620
Copy link

ModuleNotFoundError: No module named 'pandas.util'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@manishmaharjan @TijanaJakovljevic @lovetoburnswhen @H3wastooshort @Swastik1620