Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes broken exception handling on http status code != ok. #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes broken exception handling on http status code != ok. #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions betfair/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,12 @@ def __init__(self, response, data):
self.message = 'UNKNOWN'
self.details = None
super(ApiError, self).__init__(self.message)


class ApiHttpError(BetfairError):

def __init__(self, response):
self.response = response
self.status_code = response.status_code
self.message = "error http return code: %s" % self.status_code
super(ApiHttpError, self).__init__(self.message)
2 changes: 1 addition & 1 deletion betfair/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def check_status_code(response, codes=None):
else lambda resp: resp.status_code in codes
)
if not checker(response):
raise exceptions.ApiError(response)
raise exceptions.ApiHttpError(response)


def result_or_error(response):
Expand Down