Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydration animation sometimes does not play properly #394

Closed
jmakhack opened this issue Nov 8, 2022 · 0 comments · Fixed by #403
Closed

Hydration animation sometimes does not play properly #394

jmakhack opened this issue Nov 8, 2022 · 0 comments · Fixed by #403
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed java Pull requests that update Java code up for grabs Any issue that is up for grabs
Milestone

Comments

@jmakhack
Copy link
Owner

jmakhack commented Nov 8, 2022

Bug Description

On occasion, the hydration animation fails to play when a hydration interval has completed.

Steps to Reproduce

  1. In the plugin settings, set the hydration interval to 1 minute and enable hydration animation
  2. Wait for one interval to pass and observe that the animation plays
  3. Do not move the character or do anything for another minute
  4. Observe that the interval finishes but the animation does not play

Expected Behavior

The hydration animation should play after each hydration interval as long as the setting is enabled.

The issue is that in the playAnimationForLocalPlayer method, the animation is properly set but the animation frame is not set. The animation frame has to also be set for the animation to play out consistently and properly.

Environment

Operating System: MacOS Monterey
RuneLite Version: 1.9.1

Additional Context

For an example of another plugin that has fixed this issue, see: https://github.com/Enriath/external-plugins/blob/door-kicker/src/main/java/io/hydrox/doorkicker/DoorKickerPlugin.java

Please add/update any unit tests where possible.

Please refer to CONTRIBUTING.md for info on how to setup, build, run, and test this project. Feel free to ping @jmakhack in the comments below with any questions if needed. Also, join the Discord to meet and engage with other contributors!

@jmakhack jmakhack added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers java Pull requests that update Java code up for grabs Any issue that is up for grabs labels Nov 8, 2022
@jmakhack jmakhack added this to the v2.0.0 milestone Nov 8, 2022
@jmakhack jmakhack self-assigned this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed java Pull requests that update Java code up for grabs Any issue that is up for grabs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant