Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and refactor jUnit tests #387

Merged
merged 2 commits into from
Nov 5, 2022
Merged

Cleanup and refactor jUnit tests #387

merged 2 commits into from
Nov 5, 2022

Conversation

jmakhack
Copy link
Owner

@jmakhack jmakhack commented Nov 5, 2022

Associated Issue

Closes #386

Implemented Solution

Added comments in test files and refactored several tests. Also added messages to assertions.

Testing Details

Operating System: N/A
RuneLite Version: N/A

@jmakhack jmakhack added this to the Ongoing milestone Nov 5, 2022
@welcome
Copy link

welcome bot commented Nov 5, 2022

Thanks for opening this pull request for hydrate-reminder!
Please wait shortly for someone to review.
https://media.giphy.com/media/JVBV02JFVmWrut9H8j/giphy.gif

@ghost
Copy link

ghost commented Nov 5, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@jmakhack jmakhack merged commit 2e76761 into master Nov 5, 2022
@jmakhack jmakhack deleted the refactor-tests branch November 5, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup and refactor hydrate reminder test files
1 participant