Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update all-contributorsrc to show 7 contributors per line #381

Merged
merged 1 commit into from
Nov 2, 2022
Merged

update all-contributorsrc to show 7 contributors per line #381

merged 1 commit into from
Nov 2, 2022

Conversation

MrinaliniU
Copy link
Contributor

Associated Issue

Closes #371

Implemented Solution

Updated the contributorsPerLine to 7 from 5.

Testing Details

Operating System: NA
RuneLite Version: NA

Screenshots

@MrinaliniU MrinaliniU requested a review from jmakhack as a code owner November 1, 2022 07:09
@welcome
Copy link

welcome bot commented Nov 1, 2022

Thanks for opening this pull request for hydrate-reminder!
Please wait shortly for someone to review.
https://media.giphy.com/media/JVBV02JFVmWrut9H8j/giphy.gif

@ghost
Copy link

ghost commented Nov 1, 2022

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@jmakhack jmakhack added this to the Ongoing milestone Nov 1, 2022
@MrinaliniU
Copy link
Contributor Author

@jmakhack Hello :) if you think this PR looks good do you think you can merge this? thank you!

@jmakhack
Copy link
Owner

jmakhack commented Nov 2, 2022

Looks good. I was just checking with the current assignee to see if they were still working on this.

Can you leave a comment in #371 so I can assign it to you?

@MrinaliniU MrinaliniU mentioned this pull request Nov 2, 2022
Closed
@MrinaliniU
Copy link
Contributor Author

Looks good. I was just checking with the current assignee to see if they were still working on this.

Can you leave a comment in #371 so I can assign it to you?
@jmakhack Thank you! I have added a comment in the issue requesting you to assign the issue #371 to me.

@jmakhack
Copy link
Owner

jmakhack commented Nov 2, 2022

@all-contributors please add @MrinaliniU for docs

@allcontributors allcontributors bot mentioned this pull request Nov 2, 2022
Merged
@allcontributors
Copy link
Contributor

@jmakhack

I've put up a pull request to add @MrinaliniU! 🎉

@jmakhack jmakhack merged commit 44c3bbd into jmakhack:master Nov 2, 2022
@welcome
Copy link

welcome bot commented Nov 2, 2022

Congrats on merging your first pull request to hydrate-reminder!
Please give our project a star if you like what we are building here.
https://media.giphy.com/media/6RbEFpsxCOVOBUoJc4/giphy.gif

@jmakhack jmakhack mentioned this pull request Nov 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmakhack jmakhack jmakhack approved these changes

Assignees

@MrinaliniU MrinaliniU

Labels
None yet
Projects
None yet
Milestone
Ongoing
Development

Successfully merging this pull request may close these issues.

[First Timers Only] Update contributors display to show 7 contributors per line
2 participants
@MrinaliniU @jmakhack