Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[First Timers Only] Fix literals first in comparisons issue #328

Closed
jmakhack opened this issue Oct 12, 2022 · 2 comments · Fixed by #344
Closed

[First Timers Only] Fix literals first in comparisons issue #328

jmakhack opened this issue Oct 12, 2022 · 2 comments · Fixed by #344
Assignees
@vikash485
Labels
best practices Improve the health of the codebase first-timers-only For first time contributors only good first issue Good for newcomers hacktoberfest This issue qualifies for the hacktoberfest event help wanted Extra attention is needed java Pull requests that update Java code up for grabs Any issue that is up for grabs
Milestone
Ongoing

Comments

@jmakhack
Copy link
Owner

Note: This issue is to be picked up by first time contributors to this project only. If it is not picked up after ~7 days, it will be opened up for anyone to take.

Task Context

The Codacy Static Code Analysis system is reporting a literals first in comparisons issue(s). The reported issue(s) can be found at:

https://app.codacy.com/gh/jmakhack/hydrate-reminder/issues?bid=22863237&filters=W3siaWQiOiJMYW5ndWFnZSIsInZhbHVlcyI6WyJKYXZhIl19LHsiaWQiOiJDYXRlZ29yeSIsInZhbHVlcyI6WyJDb2RlU3R5bGUiXX0seyJpZCI6IkxldmVsIiwidmFsdWVzIjpbXX0seyJpZCI6IlBhdHRlcm4iLCJ2YWx1ZXMiOlsiMjM1MjkiXX0seyJpZCI6IkF1dGhvciIsInZhbHVlcyI6W119XQ==

Acceptance Criteria / Goals

The goal of this task is to fix the issue(s) reported by Codacy.

Additional Notes

After opening a pull request, the Codacy Static Code Analysis will automatically run. It should report that the fixed issue(s) if this task is completed successfully.

Please refer to CONTRIBUTING.md for info on how to setup, build, run, and test this project. Feel free to ping @jmakhack in the comments below with any questions if needed. Also, join the Discord to meet and engage with other contributors!
@jmakhack jmakhack added help wanted Extra attention is needed good first issue Good for newcomers java Pull requests that update Java code best practices Improve the health of the codebase hacktoberfest This issue qualifies for the hacktoberfest event up for grabs Any issue that is up for grabs first-timers-only For first time contributors only labels Oct 12, 2022
@jmakhack jmakhack added this to the Ongoing milestone Oct 12, 2022
@vikash485
Copy link
Contributor

Hey @jmakhack , I would like to try and contribute to this issue.

@vikash485 vikash485 mentioned this issue Oct 13, 2022
Merged
@vikash485
Copy link
Contributor

I have made a pr for this issue, please verify @jmakhack. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vikash485 vikash485

Labels
best practices Improve the health of the codebase first-timers-only For first time contributors only good first issue Good for newcomers hacktoberfest This issue qualifies for the hacktoberfest event help wanted Extra attention is needed java Pull requests that update Java code up for grabs Any issue that is up for grabs
Projects
None yet
Milestone
Ongoing
Development

Successfully merging a pull request may close this issue.

Update HydrateReminderPlugin.java
2 participants
@jmakhack @vikash485