Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[First Timers Only] Fix JUnit 5 tests should be package-private issue #327

Closed
jmakhack opened this issue Oct 12, 2022 · 6 comments · Fixed by #363
Closed

[First Timers Only] Fix JUnit 5 tests should be package-private issue #327

jmakhack opened this issue Oct 12, 2022 · 6 comments · Fixed by #363
Assignees
Labels
best practices Improve the health of the codebase first-timers-only For first time contributors only good first issue Good for newcomers help wanted Extra attention is needed java Pull requests that update Java code testing Unit or functional test work needed up for grabs Any issue that is up for grabs
Milestone

Comments

@jmakhack
Copy link
Owner

Note: This issue is to be picked up by first time contributors to this project only. If it is not picked up after ~7 days, it will be opened up for anyone to take.

Task Context

The Codacy Static Code Analysis system is reporting a Junit 5 package-private issue(s). The reported issue(s) can be found at:

https://app.codacy.com/gh/jmakhack/hydrate-reminder/issues?bid=22863237&filters=W3siaWQiOiJMYW5ndWFnZSIsInZhbHVlcyI6WyJKYXZhIl19LHsiaWQiOiJDYXRlZ29yeSIsInZhbHVlcyI6WyJDb2RlU3R5bGUiXX0seyJpZCI6IkxldmVsIiwidmFsdWVzIjpbXX0seyJpZCI6IlBhdHRlcm4iLCJ2YWx1ZXMiOlsiMzU5NzAiXX0seyJpZCI6IkF1dGhvciIsInZhbHVlcyI6W119XQ==

Acceptance Criteria / Goals

The goal of this task is to fix the issue(s) reported by Codacy.

Additional Notes

After opening a pull request, the Codacy Static Code Analysis will automatically run. It should report that the fixed issue(s) if this task is completed successfully.

Please refer to CONTRIBUTING.md for info on how to setup, build, run, and test this project. Feel free to ping @jmakhack in the comments below with any questions if needed. Also, join the Discord to meet and engage with other contributors!

@jmakhack jmakhack added help wanted Extra attention is needed good first issue Good for newcomers testing Unit or functional test work needed java Pull requests that update Java code best practices Improve the health of the codebase up for grabs Any issue that is up for grabs first-timers-only For first time contributors only labels Oct 12, 2022
@jmakhack jmakhack added this to the Ongoing milestone Oct 12, 2022
@sanjeev0210
Copy link
Contributor

I am a first time contributor to this repository, can I pick this issue?

@jmakhack
Copy link
Owner Author

go for it @sanjeev0210! :)

@sanjeev0210
Copy link
Contributor

sanjeev0210 commented Oct 13, 2022

Thank you @jmakhack :)

@sanjeev0210
Copy link
Contributor

sanjeev0210 commented Oct 14, 2022

I have made the changes but I am not able to run the files locally.
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':test'
Caused by: org.gradle.api.tasks.testing.TestExecutionException: No tests found for given includes: [com.hydratereminder.command.total.TotalCommandHandlerTest](--tests filter)
I have searched through stack overflow and tried one of the solutions, any inputs on this @jmakhack ? I have set JAVA_HOME to 1.8 by the way

@jmakhack
Copy link
Owner Author

I have made the changes but I am not able to run the files locally. org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':test' Caused by: org.gradle.api.tasks.testing.TestExecutionException: No tests found for given includes: [com.hydratereminder.command.total.TotalCommandHandlerTest](--tests filter) I have searched through stack overflow and tried one of the solutions, any inputs on this @jmakhack ? I have set JAVA_HOME to 1.8 by the way

I'm not sure what the issue is just from that error message alone. Did you follow the steps in CONTRIBUTING.md such as setting the -ea VM option? Running the project through those steps should also run the unit tests automatically as well.

If you can't get the tests running locally, you can also just open a pull request and the tests will be automatically run on our pipeline.

@sanjeev0210
Copy link
Contributor

okay Thanks @jmakhack :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best practices Improve the health of the codebase first-timers-only For first time contributors only good first issue Good for newcomers help wanted Extra attention is needed java Pull requests that update Java code testing Unit or functional test work needed up for grabs Any issue that is up for grabs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants