Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to store persistent values in a JSON file #322

Closed
jmakhack opened this issue Oct 12, 2022 · 1 comment · Fixed by #350
Closed

Add ability to store persistent values in a JSON file #322

jmakhack opened this issue Oct 12, 2022 · 1 comment · Fixed by #350
Assignees
Labels
best practices Improve the health of the codebase hacktoberfest This issue qualifies for the hacktoberfest event help wanted Extra attention is needed java Pull requests that update Java code up for grabs Any issue that is up for grabs
Milestone

Comments

@jmakhack
Copy link
Owner

Task Context

As part of #311, new functionality was added to log the total amount of hydration breaks for a user across multiple sessions. The value is currently stored in totalHydrationBreaks.log as a numeric value. The goal for this task is to store the value in a json file instead to allow for new potential fields to be added in the future.

Acceptance Criteria / Goals

The acceptance criteria for this task is to replace the totalHydrationBreaks.log usage with a new json file HydrationReminderStats.json.

The json object stored should look something like the following:

{
    "totalHydrateCount": 0
}

This will allow for more fields and persistent data to be added in the future as needed.

Additional Notes

There should be other RuneLite plugins that follow this design as well. They may be a good resource to look into to see how they handle this issue. For example: https://github.com/zenpj/eclectic-jars/blob/master/src/main/java/com/eclectic/EclecticPlugin.java

Please refer to CONTRIBUTING.md for info on how to setup, build, run, and test this project. Feel free to ping @jmakhack in the comments below with any questions if needed. Also, join the Discord to meet and engage with other contributors!

@jmakhack jmakhack added help wanted Extra attention is needed java Pull requests that update Java code best practices Improve the health of the codebase hacktoberfest This issue qualifies for the hacktoberfest event up for grabs Any issue that is up for grabs labels Oct 12, 2022
@jmakhack jmakhack added this to the v2.0.0 milestone Oct 12, 2022
@jmakhack jmakhack added java Pull requests that update Java code and removed java Pull requests that update Java code labels Oct 12, 2022
@Jacoberson
Copy link
Contributor

@jmakhack I can do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best practices Improve the health of the codebase hacktoberfest This issue qualifies for the hacktoberfest event help wanted Extra attention is needed java Pull requests that update Java code up for grabs Any issue that is up for grabs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants