Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve example message by including message type #297

Merged
merged 10 commits into from
Oct 7, 2022

Conversation

Jacoberson
Copy link
Contributor

Associated Issue

Include chat message type in example chat message
Closes #295

Implemented Solution

Add variable for chat message type and used String.format to include it in the message

Testing Details

Tested in game

Operating System: Windows 11
RuneLite Version: 1.9.0

Screenshots

image

@ghost
Copy link

ghost commented Oct 6, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@jmakhack jmakhack added this to the v2.0.0 milestone Oct 7, 2022
@jmakhack jmakhack merged commit 6e3d90a into jmakhack:master Oct 7, 2022
@Jacoberson Jacoberson deleted the improveExampleMessage branch October 13, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve chat notification example message
3 participants