Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InPlace modification should be skipped if commit isn't the latest commit #32

Open
jlewi opened this issue May 18, 2023 · 0 comments
Open

Comments

@jlewi
Copy link
Owner

jlewi commented May 18, 2023

#30 Added a GitHubApp that runs in place modification on every push and creates a PR to check in the changes.

Its possible that the renderer ends up getting triggered on a commit that is behind head.
https://github.com/jlewi/hydros/pull/30/files#diff-ad303975c31a2f01c500848b146471057f1a22957f224914d4e43061f9f115dfR103

In this case we should probably skip running in place modification. It doesn't make sense to run in place modifications using configuration which is already out of date. Rather we should skip it and run on the latest configuration.
Right now the code always runs on the latest configuration even when triggered via a different commit; e.g. suppose we have commits
abcdef (older)
123456 (newer)

Then its possible the run triggered by abcdef will execute when 123456 is the latest commit. The renderer will use the commit from 123456. However, its confusing that the checkrun on abcdef is using code from a different commit. It makes more sense for the checkrun on abcdef to be skipped because it is no longer the latest commit.

jlewi added a commit that referenced this issue May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant