Disable NORETURN annotation on PROCAbort for Arm

jkotas · jkotas · commit 930ee7be3a51 · 2024-03-11T23:49:58.000-07:00
Contributes to dotnet#86273
diff --git a/src/coreclr/pal/src/include/pal/process.h b/src/coreclr/pal/src/include/pal/process.h
@@ -155,7 +155,10 @@ BOOL PROCAbortInitialize();
 
   Does not return
 --*/
+#if !defined(HOST_ARM)  // PAL_NORETURN produces broken unwinding information for this method
+                        // making crash dumps impossible to analyze
 PAL_NORETURN
+#endif
 VOID PROCAbort(int signal = SIGABRT, siginfo_t* siginfo = nullptr);
 
 /*++
diff --git a/src/coreclr/pal/src/thread/process.cpp b/src/coreclr/pal/src/thread/process.cpp
@@ -2541,7 +2541,9 @@ PROCCreateCrashDumpIfEnabled(int signal, siginfo_t* siginfo, bool serialize)
 
   Does not return
 --*/
+#if !defined(HOST_ARM)
 PAL_NORETURN
+#endif
 VOID
 PROCAbort(int signal, siginfo_t* siginfo)
 {

Original file line number	Diff line number	Diff line change
`@@ -2541,7 +2541,9 @@ PROCCreateCrashDumpIfEnabled(int signal, siginfo_t* siginfo, bool serialize)`
`2541`	`2541`
`2542`	`2542`	`Does not return`
`2543`	`2543`	`--*/`
	`2544`	`+#if !defined(HOST_ARM)`
`2544`	`2545`	`PAL_NORETURN`
	`2546`	`+#endif`
`2545`	`2547`	`VOID`
`2546`	`2548`	`PROCAbort(int signal, siginfo_t* siginfo)`
`2547`	`2549`	`{`