Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

end() method does not close connections #4

Open
viamuli opened this issue Feb 1, 2019 · 1 comment
Open

end() method does not close connections #4

viamuli opened this issue Feb 1, 2019 · 1 comment

Comments

@viamuli
Copy link

viamuli commented Feb 1, 2019

Tested with NodeJs 8.x and 10.x in AWS Lambda and local Ubuntu.
It appears the end() method does not close connections at all - it still is possible to get/set without any problem which leads to unexpected behaviour such as lambda functions timing out while everything has been processed successfully and the final callback has been called.
@cosmic-chichu
Copy link

#2 This is why it is not closed, fix this typo and it should work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cosmic-chichu @viamuli