Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moderator on moderated.jitsi.net not supported (redirect issue) #705

Open
OrionRandD opened this issue Feb 8, 2022 · 9 comments
Open

Moderator on moderated.jitsi.net not supported (redirect issue) #705

OrionRandD opened this issue Feb 8, 2022 · 9 comments
Assignees

Comments

@OrionRandD
Copy link

How can I have moderator powers in jitsi-meet-electron?
Do you provide this feature?

https://moderated.jitsi.net/

If not, could you add it?
Thx

@saghul
Copy link
Member

saghul commented Feb 8, 2022

Good point. We probably need to change things around and do a HEAD request to resolve the real URL... And then parse the jwt and pass it along.

A PR in this space would be welcome.

@OrionRandD
Copy link
Author

OrionRandD commented Feb 9, 2022 via email

@saghul
Copy link
Member

saghul commented Feb 9, 2022

Thx for replying. Could you make that PR for me? I do now know how to do that... Since I, and yourself, seem to agree in this point here.

Will do when I have some time.

Another suggestion I would give is NOT to allow jitsi-electron to send an invitation to join a certain room without the person who opened the room to set a password before sending the invitation...

There is no reason to enforce that, it's the user's responsibility.

@csett86 csett86 changed the title How can I have moderator powers in jitsi electron? Moderator on moderated.jitsi.net not supported (redirect issue) Jul 3, 2022
@csett86
Copy link
Member

csett86 commented Jul 24, 2022

While revisiting this and checking how moderated.jitsi.net works, I don't see a way how to enable this into the electron app.

moderated.jitsi.net hides the real URL with JWT and only redirects to it when clicking a button:

Bildschirmfoto 2022-07-24 um 15 07 39

Source: https://github.com/jitsi/moderated-meetings/blob/master/src/main/js/screens/Join.tsx#L152-L157

So unless this is changed in moderated.jitsi.net to directly expose the URL containing the JWT, I don't see how this would work in the electron app. Any suggestions @saghul?

@saghul
Copy link
Member

saghul commented Jul 25, 2022

@csett86 Yep, you're right. We'd need to add a way to copy the real link.

@csett86
Copy link
Member

csett86 commented Jul 29, 2022

@saghul I could provide an updated implementation as PR for the moderated-meetings that looks like this:

Bildschirmfoto 2022-07-29 um 18 28 07

This changes the room names to url sanitized base64 (ie "/" -> "-" and "+" -> "_") names so that the room names are shorter and then extends the view to 720px so that the normal and moderator URL also look different.

What do you think?

@csett86
Copy link
Member

csett86 commented Jul 30, 2022

Its not a good idea, it would break all existing moderated meetings by assigning them a new room. I‘ll try a different route

@saghul
Copy link
Member

saghul commented Jul 30, 2022

Thanks for looking into this.

@csett86 csett86 self-assigned this Jul 31, 2022
@csett86
Copy link
Member

csett86 commented Jul 31, 2022

I think I got something now that allows to share the moderation link and also keeps backwards compatibility:

jitsi/moderated-meetings#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants