Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PermutedDimsArray #63

Open
antoine-levitt opened this issue Jun 10, 2022 · 2 comments
Open

PermutedDimsArray #63

antoine-levitt opened this issue Jun 10, 2022 · 2 comments

Comments

@antoine-levitt
Copy link

Hi @jipolanco, just watching your talk now and have a technical question: for the custom permutated array that you seem to have, can't you just use PermutedDimsArray?

@antoine-levitt
Copy link
Author

Ah sorry I posted too fast, I thought you weren't going to come back to it but I see you did, sorry! Would be nice to have these improvements directly in julia Base!

@jipolanco
Copy link
Owner

I agree! And thanks for mentioning this. At some point I was planning to propose something like this for Julia base, but I wanted first to have a proper reference implementation of a PermutedDimsArray alternative.

The thing is that, for now, the PencilArray type includes code for dealing with permutations + all the other stuff that I presented. So the idea is to take the permutation stuff out of PencilArray, and define a PermutedDimsArray-like type which implements this. This type will likely be defined in the (very lightweight) StaticPermutations.jl package, which already defines the Permutation type and a few permutation operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants