Typescript Support

[Manuelandro]

Is it something that could interest you? I think i'm gonna implement it on my clone for personal use, but if you'd like I could open a pull request

[kamikazebr]

Hey @Manuelandro I have interest in TS too, link here your progress i think i could help.

[nuke-web3]

He @Manuelandro @kamikazebr - any word on progress here? 😁

[tarrball]

Is anybody actively developing on this? I've started work on migrating the template over to TypeScript.

[kamikazebr]

@nukemandan @tarrball I had hope @Manuelandro already had some WIP on that, but not got awnser, I have some time to help but not to start of migration.

So @tarrball if you need some sporadic help on that i'll happy support.

[tarrball]

@kamikazebr I've got the template working with TypeScript, with some package warnings & eslint removed, so there's some work to be done still. I've got the repo forked here to work on it. I'm not sure if that's the best or desired way for me to proceed with development for the greater good, but it's how I started it for myself.

[kamikazebr]

Hey @tarrball i saw some commits there, amazing! Yah i think fork is way to go working on one branch to PR later. I never worked on fork-fork project, but i have almost sure i just need add new remote, and make amends if necessary on your branch.

About the workflow, i think part will run on Issue on your fork and linked here on that.

What you think need be done there yet? I'll fetch and run on my local

[kamikazebr]

@nukemandan @tarrball i had tested and run the code, its look great. Should create some branch and PR to merge here?

[tarrball]

I dropped eslint, since it was having build issues (related to webpack in some way, I think), so that's one issue. There are couple other minor things (like having to hard code the color in the transaction button component) that I hastily did to get things building.

Other than that, other questions/concerns I have are: I don't know how this fits in with the current repo. Is there a desire to replace what's in place with a TypeScript solution, or is there a desire to maintain both? Are there any code snippers or tutorials that would need to be updated to note the changes?

[tarrball]

I've got this working fully now without any issues.

[nuke-web3]

cool @tarrball ! 😁
.... maybe a PR here?
I think we could maintain an alt branch of this with your support that is pure TS... or with the maintainers buy-in, move to this over js.

[tarrball]

@kamikazebr @nukemandan PR opened -> #223

[fuzzc0re]

Made some enhancements to this PR here --> tarrball#1
Hope this will bring us closer to a strongly typed template.
Cheers.

[tarrball]

I've made good progress on this and kept current with the main branch on my own fork, but I'm not sure how far to go with the typings. Do we want to create typings that match all the pallets/RPC's in the main branch? I think avoiding all "any" types is going to be tough.

It's not trivial to rebase each time there are significant change on main, so I'm just wondering what the definition of "done" is on this issue?

[langdon0003]

@tarrball are you working on this issue still? I wanna jump to help. Let get it done?

@nukemandan may help to solve it as I wanna help Tarrball to follow it.

[tarrball]

@langdon0003 no I haven't done anything on this since my last comment, but it doesn't seem like much has changed in this repo since then, so it seems like it's stable enough to make the switch to TS. As long as there is enough buy-in and a good definition of "done" to work toward (as mentioned a few months ago).

[langdon0003]

@langdon0003 no I haven't done anything on this since my last comment, but it doesn't seem like much has changed in this repo since then, so it seems like it's stable enough to make the switch to TS. As long as there is enough buy-in and a good definition of "done" to work toward (as mentioned a few months ago).

I am currently checking on this repo [email protected]:tarrball/substrate-front-end-template.git at "ts/main" branch but It look like still have done yet.

Am I checkout right repo? Could you update the latest and work one? Thank you so much!

[tarrball]

@langdon0003 the last time I rebased, it was into this branch https://github.com/tarrball/substrate-front-end-template/tree/ts-again. I got pretty far into it but it's been silent for a while so I haven't messed with it since

[Chralt98]

@tarrball Does your last version work? I can't really get the version running from the https://github.com/tarrball/substrate-front-end-template/tree/ts-again and from this repository for Typescript.