-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maybe need add libwebp.7.dylib
to Frameworks
folder?
#85
Comments
After manually copy
Maybe script can add an optional config that add the homebrew lib path to |
Make PR #86 |
I ran into the same issues building |
Thanks for the report and PR @ccqpein. I’ll try and find some time to have a proper look at this before the end of the week. I have a feeling it’s a combination of new optional configure flags in emacs which automatically enable themselves if specific brew packages happen to be installed, along with what looks like a potential bug with the shared library embedding code in the build script. |
@ccqpein Apologies, it took me longer to get around to this than I thought. However I can't re-produce it on my own machines. I don't have any Apple Silicon machines available to me, but I don't think it's an Intel vs AS issue. For what it's worth, in my pre-builds project, the 29.0.92-pretest build for example includes the So I'm not fully sure what might be going on. The fact that it's linked to via Since I can't re-produce it myself, I'm afraid I might need to ask you debug things a bit further. I have just pushed a new v0.6.42 of build-emacs-for-macos, which has a new You can also try to use the Let me know if there's anything more information I can give you, or help you with further debugging in general. |
@jimeh no need to apologies. I am trying to rebuild with your update now. I will keep this issue updated. Thank you! |
There are outputs of
|
Then I searched the output of buildin. For
|
@ccqpein I believe I've tracked down the root of the issue. The original |
I just build the Emacs master branch, and looks like there are some
Looks like it still the old
|
Thanks for the details :)... Thankfully I've already come across that one too. It's because the shared library links to other shared libraries using These issues have necessitated a rewrite of said code, and I have a nearly working version of it locally. I just need to find some more time this week to iron out a few bugs before it'll work properly. |
Hi @jimeh. Any news on this? :)
Thanks! |
Hi @jimeh How is everything going? Do you need more test or log info I can help with? Thanks. |
I'm also experiencing this on my M1 Macbook Pro, running Ventura 13.5.2.
and indeed
|
My build log (just the bundling part) is in this gist: https://gist.github.com/garyo/6a6dec778dfa98c35e4a03623df21ce6 in case it's helpful. |
Apologies for the radio silence everyone. Tail end of the summer got a bit crazy so I've not had any time available to look at this (and a few other things). Things are returning to normal this month though, so I'll be getting this sorted out soon. |
FWIW, I did these additional commands and now it's working on my M1 mac:
|
@jimeh Hope everything is fine. Let me know if you need more logs or test. Thanks! |
Is there any workaround for this issue? This appears to be the only Emacs build that offers casks with native-comp, I would love to help out here in any way I can. |
Just a quick note to say that @jimeh 's |
@garyo @ccqpein That's great to hear, and thanks for testing that branch out. Last time I touched it, it was failing spectacularly for me. But it was middle of the night and I was half asleep, so I was probably doing something stupid... lol I've got time set aside over the next couple of weeks to sort this issue out properly. And I'm also getting my first Apple Silicon machine this month, so I'll be able to properly try and document the process there too :) |
@garyo @ccqpein Thanks for your patience. I have updated #88 and fixed the outstanding issues on it, which was that it did not actually re-link anything after copying in all the relevant shared libraries into the Emacs.app bundle. If you have time and are willing, feel free to try out the latest changes in #88. My plan is to wrap up and merge it tomorrow if no issues have cropped up with it.
Personally I've tested Emacs builds from it which seem to fully work on completely fresh installs of macOS with only the Xcode Command Line Tools installed. And I've tested it on Apple Silicon, as I finally upgraded from an old Intel-mac last week. Later this week my plan is to focus on getting the nightly builds repo and homebrew tap updated, along with ARM64 builds for Apple Silicon machines too. |
Problems:
After build the emacs, and
codesign
(#64). My mac return me the panic report that:Temporary solution:
After some research and debugging, I find it the
@rpath
value ispath @executable_path/../Frameworks (offset 12)
. After I add homebrew's lib path to@rpath
byinstall_name_tool -add_rpath /opt/homebrew/lib /Applications/Emacs.app/Contents/MacOS/Emacs
. The problem is solved. It can get thelibwebp.7.dylib
now.I checked the code and find line 170 define
extra_libs
which copy toFrameworks
in embed (maybe? I don't know Ruby).Maybe we can also copy
libwebp.7.dylib
too? Thanks!My env:
macOS 13.4.1
M2 Max
GNU Emacs master branch
The text was updated successfully, but these errors were encountered: