Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Bundle in URL when shouldn't be #1010

Open
joeflack4 opened this issue Dec 8, 2024 · 1 comment
Open

UX: Bundle in URL when shouldn't be #1010

joeflack4 opened this issue Dec 8, 2024 · 1 comment
Assignees
Labels
bug Something isn't working ux issue User-experience related issue

Comments

@joeflack4
Copy link
Member

joeflack4 commented Dec 8, 2024

Overview

I think what I did was load a concept set on the home page, then went to the "help / about" page, selected a bundle (Ace inhibitors), then went to "load value sets", selected a related cset, and then went to the comparison page. Now I have this URL:

https://purple-plant-0f4023d0f.2.azurestaticapps.net/cset-comparison?bundle=ACE+inhibitors&codeset_ids=479356&codeset_ids=475972797

However ?bundle=ACE+inhibitors has no effect on the URL. It does not appear in the comparison page.

Additional info

What I originally erroneously thought the problem was

UX / bug: Selected concept sets combining with bundles

I went to the "help / about" page, selected a bundle (Ace inhibitors), then selected a couple concept sets from "load value sets", and now I'm seeing some combination of them in the comparison page:

https://purple-plant-0f4023d0f.2.azurestaticapps.net/cset-comparison?bundle=ACE+inhibitors&codeset_ids=479356&codeset_ids=475972797

I think that I may have also went to the home page first and selected a cset, then went and selected a bundle.

I haven't fully analyzed the issues here, but some problems I noticed:

  • I think there should be more concepts showing.
  • It shows all concepts as "unlinked"
  • When you select a bundle and go to the "load value sets" page, it doesn't show that a bundle is loaded.
    • Does the bundle influence the related csets that show up?
  • When I go back to "help / about", and look at the "bundle" dropdown, it does not show "ACE inhibitors" selected

Possible solutions:

  • Make these features mutually exclusive?

@joeflack4 joeflack4 added bug Something isn't working ux issue User-experience related issue labels Dec 8, 2024
@joeflack4 joeflack4 added this to TermHub Dec 8, 2024
@github-project-automation github-project-automation bot moved this to 3. Backlog in TermHub Dec 8, 2024
@joeflack4 joeflack4 changed the title UX / bug: Selected concept sets combining with bundles UX: Bundle in URL when shouldn't be Dec 8, 2024
@Sigfried
Copy link
Collaborator

Sigfried commented Dec 9, 2024

I've noticed this. Once bundle=ACE+inhibitors shows up in the query string, it doesn't disappear when navigating to pages where it's not relevant. Ugly and not great, but fixing it would take a little work and I never got around to it. It's still a bug and can remain in case we ever get more development time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ux issue User-experience related issue
Projects
Status: 3. Backlog
Development

No branches or pull requests

2 participants